Skip to content

Backend/events: Add GetEventCalendarFile API - #9326

Merged
tristanlabelle merged 11 commits into
developfrom
backend/feature/GetEventCalendarFile
Jul 26, 2026
Merged

Backend/events: Add GetEventCalendarFile API#9326
tristanlabelle merged 11 commits into
developfrom
backend/feature/GetEventCalendarFile

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This API will support a button on the frontend to download a calendar file for the event.

Includes some refactoring of the ics generation code and tests, the biggest visible result being that we now create a sequence number based on a timestamp to support an arbitrary number of updates.

Fixes #9328

Testing

Added & updated tests.

Backend checklist

  • Added tests for any new code or added a regression test if fixing a bug
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@CouchersBot

CouchersBot commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

    iOS         Android    
    QR to open the iOS build         QR to open the Android build    
    Open in Dev Tool         Open in Dev Tool    
Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2F9a18ded1--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2F9a18ded1--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

@tristanlabelle
tristanlabelle marked this pull request as ready for review July 25, 2026 18:54
@tristanlabelle
tristanlabelle requested a review from aapeliv as a code owner July 25, 2026 18:54
@tristanlabelle
tristanlabelle requested a review from a team July 25, 2026 18:54
aapeliv
aapeliv requested changes Jul 25, 2026
View reviewed changes

@aapeliv aapeliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but let's keep the to_aware_datetime function simple

Comment thread app/backend/src/couchers/utils.py Outdated
Comment thread app/proto/events.proto
@tristanlabelle
tristanlabelle force-pushed the backend/feature/GetEventCalendarFile branch from f1d857d to 9a18ded Compare July 26, 2026 11:44
@tristanlabelle

tristanlabelle commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

@aapeliv ready for final stamp

aapeliv
aapeliv approved these changes Jul 26, 2026
View reviewed changes

@aapeliv aapeliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@tristanlabelle
tristanlabelle merged commit 9dcee83 into develop Jul 26, 2026
9 checks passed
@tristanlabelle
tristanlabelle deleted the backend/feature/GetEventCalendarFile branch July 26, 2026 17:35
@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR adds backend support for downloading calendar files for events, but by itself it does not add the visible frontend button or a directly user-noticeable feature yet. The remaining changes are mostly implementation details and ICS handling improvements that users are unlikely to notice on their own.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR adds backend support for downloading calendar files for events, but by itself it does not add the visible frontend button or a directly user-noticeable feature yet. The remaining changes are mostly implementation details and ICS handling improvements that users are unlikely to notice on their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aapeliv aapeliv aapeliv approved these changes

Assignees

No one assigned

Labels

release notes: not needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Backend/events: Implement API for getting the event calendar file

3 participants

@tristanlabelle @CouchersBot @aapeliv